This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Add ability to wrap response in an envelope #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@WP-API/amigos #reviewmerge |
Closed
Member
There was a problem hiding this comment.
I hate all of these magic request arguments. There's no better way to do this?
Member
There was a problem hiding this comment.
I see this as a bit of a impossible argument - how do you expect to specify something in a space where anyone can specify anything and eradicate the possibility of conflicts?
Member
Author
There was a problem hiding this comment.
Agreed; we have a finite space here to operate in. Let's break this to another discussion (#634).
Member
|
We can take the magic request arguments to another discussion, but this should have tests. |
Member
Author
|
Good point on the tests, will do. |
Member
Author
|
Tests added, let's go-go-go @WP-API/amigos. |
Member
|
Good first pass at #679 |
danielbachhuber
added a commit
that referenced
this pull request
Dec 4, 2014
Add ability to wrap response in an envelope
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #507 from @Japh for 2.0.
Fixes #370.