Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@joehoyle
Copy link
Member

@joehoyle joehoyle commented Aug 6, 2015

Currently it builds this with str_replace which can be error prone, and
doesn't file the expected image_downsize filter than a lot of media related
plugins use to alter the image.

Currently it builds this with str_replace which can be error prone, and
doesn't file the expected `image_downsize` filter than a lot of media
related plugins use to alter the image.
@rmccue rmccue added this to the 2.0 Beta 4 milestone Aug 7, 2015
@rmccue rmccue self-assigned this Aug 7, 2015
rmccue added a commit that referenced this pull request Aug 7, 2015
Use wp_get_attachment_image_src() on the image sizes in attachments
@rmccue rmccue merged commit f4b10c7 into develop Aug 7, 2015
@rmccue rmccue deleted the attachment-urls-fix branch August 7, 2015 18:27
@rmccue
Copy link
Member

rmccue commented Aug 7, 2015

I guess we'll find out if it was using str_replace for a reason ¯_(ツ)_/¯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants