This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Ability to specify arg_options in the schema to override the arguments
#1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registration options
We need to filter out the arg_options from the schema, which means having another method to output the publicly comsumable schema.
tests/test-rest-controller.php
Outdated
Member
Author
There was a problem hiding this comment.
I could - given that I was comparing the equality in a few fields - it kind of meant sense to keep it consistent with that.
joehoyle
added a commit
that referenced
this pull request
Jun 12, 2015
This default is then use for the default arg value also. We could use this in #1345 however, we want the default specifically to be public so we can communicate to clients what th default value will be.
# Conflicts: # tests/class-wp-rest-test-controller.php # tests/test-rest-controller.php
rachelbaker
added a commit
that referenced
this pull request
Jun 12, 2015
Ability to specify `arg_options` in the schema to override the arguments
Member
|
Merged #1345 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.