BUG: Lifecycle code sample contains unexpected ":"#5
Merged
dglazkov merged 1 commit intoWICG:gh-pagesfrom Mar 17, 2014
Merged
Conversation
It looks like this sample was converted from using object literal notation to use function expressions, but one of the ":" was missed. I've replaced it with an assignment so that the sample works again.
Contributor
Author
|
This resolves the bug https://www.w3.org/Bugs/Public/show_bug.cgi?id=24398 |
dglazkov
added a commit
that referenced
this pull request
Mar 17, 2014
BUG: Lifecycle code sample contains unexpected ":"
Contributor
|
Thanks! |
This was referenced May 25, 2015
Closed
This was referenced Jul 6, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this sample was converted from using object literal notation to use function expressions, but one of the ":" was missed. I've replaced it with an assignment so that the sample works again.