Bug fix for direction in readCapytaine #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
only outstanding item is to update run capytaine results with the new input files. |
Contributor
|
@akeeste would you be able to re-run the example files and push corrected outputs or should I? Be good to merge this ASAP |
Contributor
Author
|
@dforbush2 I am running the OSWEC example now and then will finish up the last too expensive cases (RM3, COER_COMP). Should be done soon. |
Contributor
Author
|
@dforbush2 the new output data is complete and all my tasks are finished on this PR. In addition to the tasks above, I added minor clean-up on the headers that Spyder puts in python files by default. This is good to go on my end |
This was referenced Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #997 and updates:
readCapytaineto convert direction from radians (Capytaine's convention) to degrees (WEC-Sim's convention)examples/BEMIO/Capytainescripts to use radians, not degreesexamples/BEMIO/Capytaineresults