Skip to content

readCapytaine_fixes_for_reading_dataformats_correctly #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dav-og merged 2 commits into from
Oct 12, 2022
Merged

readCapytaine_fixes_for_reading_dataformats_correctly #947

dav-og merged 2 commits into from
Oct 12, 2022

Conversation

@salhus
Copy link
Contributor

@salhus salhus commented Sep 8, 2022 •
edited
Loading

This follows from the closed PR #940
#940
This PR converts the capytaine generated hydrodynamics coefficients to data formats compatible with wec-sim.
The following changes were made,

  1. Capytaine generated data needs to be converted to double format for it to be readable in MATLAB. Not having the appropriate data format was hindering the normalizeBEM.m functionality of BEMIO,
  2. The filename for the Capytaine output files was not being read by ncread() correctly. The MATLAB command split() helped fix this issue.

@salhus salhus requested a review from dav-og September 8, 2022 17:58
@jtgrasb
Copy link
Contributor

jtgrasb commented Sep 21, 2022

Seems like this may be related to #884

@dav-og dav-og merged commit a302ac6 into WEC-Sim:dev Oct 12, 2022
@salhus salhus deleted the readCapytaine_dataformat_fixes branch October 12, 2022 22:13
@dav-og dav-og assigned salhus and unassigned dav-og Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dav-og dav-og Awaiting requested review from dav-og

Assignees

@salhus salhus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@salhus @jtgrasb @dav-og