fix cable implementation #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @dforbush2 |
Collaborator
|
@dforbush2 thank you! I'll pull this into PR #822 as well |
kmruehl
added a commit
to kmruehl/WEC-Sim
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #824
Previously the mask initialization of the cable block used some 'eval()' syntax for setting the drag body mass. This fails when using multiple cables because this syntax will always try to read cable(1).cableNum, which is always 1, while the desired operation is to read cable(N).cableNum, which is always N.
This has been replaced with
'set_param(h,'Value', num2str(cable.bodyMass));'
for each the follower and the base drag body.
This is the only intended change. Tested on 2021b R1.