-
Notifications
You must be signed in to change notification settings - Fork 184
DRAFT: Warning/Error flags #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AQWA Examples (WEC-Sim#779)
|
@kmruehl Okay, I unfortunately don't have the time to do it today, but I will plan to have it merged and conflicts resolved by monday. |
|
@jtgrasb I'm actively working on #822, an extension of #803, and it will likely affect some of these warnings. For now, just focus on resolving conflicts with dev, but I wanted to let you know that dev will be changing more very soon. You can refer to the comments in #822 to see all the properties that have been changed. |
|
@jtgrasb did you mean to merge this into dev? |
|
No, I was trying to pull dev into my branch and made a mistake. Just created a PR to revert these changes. @kmruehl |
|
@kmruehl It should be reverted now. Sorry about that! |
|
@jtgrasb it's okay, we've all done it before. Let me know if it happens in the future because I can overwrite commits (instead of submitting a PR to revert them). I'm actually going to do that to the repo now to clean it up a bit. |
In this PR, I’ve implemented warning and error flags that seek to provide more feedback to the user regarding common errors and issues. The following flags/messages have been implemented into wecSim as part of this PR:
I am working on more warning and error flags, but wanted to get a PR started here so that it can start to be reviewed.