Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Dec 6, 2021

This PR adds Ansys AQWA example cases to be consistent with the example cases for WAMIT/NEMOH/Capytaine.

@akeeste akeeste self-requested a review December 6, 2021 17:24
@akeeste akeeste added BEM/BEMIO related to BEMIO or BEM hydro data Feature new feature request labels Dec 6, 2021
@kmruehl
Copy link
Collaborator

kmruehl commented Dec 7, 2021

@jtgrasb refer to #761 (comment). Can you look into the IRR issue and compare the AQWA solutions to the other BEM data, e.g. WAMIT? Also, it looks like the tests are failing due to a directory issue (RM3data versus RM3)

@jtgrasb
Copy link
Contributor Author

jtgrasb commented Dec 8, 2021

@kmruehl Thanks for fixing the RM3data issue -- I should've tested that locally first, whoops. I will work on addressing the RM3 issue.

@kmruehl
Copy link
Collaborator

kmruehl commented Dec 8, 2021

@jtgrasb I made the same mistake of forgetting to run the tests locally on the master branch, no worries, it happens :)

@akeeste akeeste requested review from kmruehl and removed request for akeeste December 8, 2021 15:46
@jtgrasb
Copy link
Contributor Author

jtgrasb commented Jan 12, 2022

I made improvements to the RM3 example based on the examples in the shared drive. I am still getting instabilities in the radiation damping and the added mass plots. I even tried running the examples on the shared drive and got similar instabilities. The peaks are minimal for the heave motion though.
rad
add

@kmruehl
Copy link
Collaborator

kmruehl commented Jan 24, 2022

@jtgrasb thank you so much, this looks great! I compared the RM3 results between AQWA and WAMIT, and they have very good agreement for Heave, but agreement is not so great in Surge/Pitch. So the good news is the frequency spike around 2 rad/s for the AQWA RM3 results is not affecting the primary (power take-off) DOF. Overall these results are much improved and we should go ahead and merge them.

I also compared:

  • Coe_comp results between AQWA and WAMIT, they have good agreement in all 3 DOFs.
  • Cubes results between AQWA and WAMIT, they have good agreement in all 3 DOFs.
  • Cylinder results between AQWA and WAMIT, they have good agreement in all 3 DOFs.
  • Ellipsoid results between AQWA and WAMIT, they have good agreement in all 3 DOFs. But the AQWA results at higher frequencies aren't very smooth. Was this case run with equal period spacing? If so, please run it with equal frequency spacing.
  • OSWEC results between AQWA and WAMIT, they have good agreement in all 3 DOFs.
  • Sphere results between AQWA and WAMIT, not very many frequencies for the AQWA run, this should be rerun.
  • WEC3 results between AQWA and WAMIT, the AQWA results have a lot of spikes for low frequencies. This may be worth investigating.

@kmruehl
Copy link
Collaborator

kmruehl commented Jan 24, 2022

@jtgrasb I'm going to go ahead and merge this PR so that we can add the AQWA examples into dev, thank you! Can you open a new PR to update the AQWA runs for the Ellipsoid, Sphere, and WEC3?

@kmruehl kmruehl merged commit 0440cb8 into WEC-Sim:dev Jan 24, 2022
jtgrasb added a commit to jtgrasb/WEC-Sim that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BEM/BEMIO related to BEMIO or BEM hydro data Feature new feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants