Resolving #497 bug with body.cb #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dforbush2
approved these changes
Feb 12, 2021
nathanmtom
approved these changes
Feb 12, 2021
nathanmtom
left a comment
There was a problem hiding this comment.
The code updates are appropriate for adding body(ii).cb when not defined by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #497 by setting cb=cg if it's not defined and adding a warning. This is true for both non-hydro bodies and drag bodies.
@nathanmtom please test with a non-hydro body case (e.g. WECCCOMP) by commenting out body.cb in the input file.
@dforbush2 please test by a drag by case by commenting out body.cb in the input file.
You should get a warning that says something like