Skip to content

Updated MOST source code #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akeeste merged 31 commits into from
Jul 28, 2025
Merged

Updated MOST source code #1470

akeeste merged 31 commits into from
Jul 28, 2025

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented May 15, 2025 •
edited
Loading

This is a PR to start discussions about pulling in updates from the MOST source code into WEC-Sim.
@MOREnergylab @DavideIssoglio is MOST at a point where we can pull updates into WEC-Sim?

TODO

  • update documentation
    • changes to windTurbineClass and windClass
    • In docs, define MOST before using
    • Release notes for MOST v2.0
    • New citation --> not yet. MOST team will update docs after the release

@akeeste
Copy link
Contributor Author

akeeste commented May 15, 2025 •
edited
Loading

This PR has not been reviewed or revised, but changes should now be limited to new updates in MOREnergyLab/WEC-_Sim_MOST while maintaining current WEC-Sim source changes

@kmruehl kmruehl added the MOST updates related to the MOST software label May 15, 2025
@kmruehl kmruehl assigned jtgrasb and unassigned jtgrasb May 28, 2025
@kmruehl kmruehl requested a review from MShabara May 28, 2025 14:45
@akeeste
Copy link
Contributor Author

akeeste commented May 28, 2025

@akeeste also reviewing. Can't tag since it's from my branch

@akeeste akeeste marked this pull request as ready for review July 1, 2025 18:27
akeeste
akeeste commented Jul 1, 2025
View reviewed changes
Copy link
Contributor Author

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MShabara I finished my initial review. I think there's a couple things for us to update on the mooringClass. There's possible but functionally unnecessary refactoring we could do on the MOST source as well.

source/objects/windClass.m
Copy link
Contributor Author

@akeeste akeeste Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally there is some light refactoring that we could do here to make it fit with WEC-Sim source better. It's a very small class so it's not much effort, but it may be worth leaving it as since it falls under MOST team maintenance

Copy link
Contributor

@DavideIssoglio DavideIssoglio Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of writing this class not much attention was paid to respecting the style of the other WEC-Sim classes, your corrections to make them fit better with WEC-Sim source are therefore appreciated, thank you.

@akeeste
Copy link
Contributor Author

akeeste commented Jul 2, 2025

Thank you for the comments @DavideIssoglio! It is much appreciated. I'll finish up some changes based on your comments. Please let me know if I missed any changes related to MOST. There was a lot to combine with the other changes in WEC-Sim's source

akeeste
akeeste commented Jul 9, 2025
View reviewed changes
@akeeste
Copy link
Contributor Author

akeeste commented Jul 17, 2025 •
edited
Loading

One of the last things I'm doing on this PR is to run the MOST examples https://github.com/MOREnergylab/MOST/tree/master/Examples and ensure they are all working

  • 2Turbines
  • HybridSpar
  • VolturnUS

@akeeste
Copy link
Contributor Author

akeeste commented Jul 23, 2025

I'm working through one more issues with the new nonlinearstatic mooring option. Hopefully I can figure that out quickly

@akeeste
Copy link
Contributor Author

akeeste commented Jul 24, 2025 •
edited
Loading

Thank you very much @jtgrasb for helping fix the last bug I created in the mooring refactoring. With a few corresponding changes to input files (below), the three cases https://github.com/MOREnergylab/MOST/tree/master/Examples run successfully!

@DavideIssoglio Required changes to the linked examples to make them run:

  • for mooring look up tables:
    • the lookup table data file should only contain one struct
    • specify file extension when defining the lookup table data file
    • add mooring(1).lookupTableFlag=1; to the input file
  • for the nonlinear static mooring method
    • add flag=1 to the mooring.nonlinearStaticData definition in the input file
    • mooring.nonlinearStaticData.linear_air_mass to mooring.nonlinearStaticData.linearAirMass
    • mooring.nonlinearStaticData.number_lines to mooring.nonlinearStaticData.nLines
    • in the block mask, define both mooring(i) and mooring(i).nonlinearStaticData
  • windClass
    • wind.ConstantWindFlag to wind.constantWindFlag
    • wind.v_time_breakpoints to wind.timeBreakpoints
    • wind.v_modules to wind.modules
    • wind.v_directions to wind.directions

akeeste
akeeste commented Jul 24, 2025
View reviewed changes
@jtgrasb jtgrasb mentioned this pull request Jul 24, 2025
Merged
13 tasks
@akeeste
Copy link
Contributor Author

akeeste commented Jul 28, 2025

I updated the release notes with more detail. Merging once the tests pass

@akeeste akeeste merged commit 5b3f21b into WEC-Sim:dev Jul 28, 2025
10 checks passed
@jtgrasb jtgrasb mentioned this pull request Aug 6, 2025
Merged
MShabara pushed a commit that referenced this pull request Aug 9, 2025
@jtgrasb
[BUG] Add back MoorDyn blocks (removed by #1470) (#1522)
d8a113f 
* Add back moordyn blocks

* Add MoorDyn Caller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MShabara MShabara Awaiting requested review from MShabara

1 more reviewer

@DavideIssoglio DavideIssoglio DavideIssoglio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MShabara MShabara

Labels

MOST updates related to the MOST software

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akeeste @DavideIssoglio @kmruehl @MShabara @jtgrasb