readCapytaine - get Khs from .nc files when bodies have less than 6 DOFs #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Collaborator
|
@akeeste how do you recommend testing this feature? |
Contributor
Author
We were using a TEAMER case internally. I'll upload a simple sample case |
Contributor
Author
|
@kmruehl In running a couple test cases and edge cases, I ran into an issue. I'll work through it and let you know when the fix is pushed |
…_readCapytaine_khs
Contributor
Author
|
@jleonqu I think I fixed the bug in this PR. I attached a zip of several edges cases to test against. |
38d6543 to
8c7a137
Compare
Contributor
Author
|
Thanks @jleonqu! |
Collaborator
|
Thanks @jleonqu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds onto #1263 and allows
readCapytaineto process hydrostatic stiffness (Khs) from the .nc file when there are multiple bodies with <6 DOFs.Testing this depends on the bugfix in #1274 and should be merged after that PR.