readCapytaine - fix reading multiple bodies with <6 dofs #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jniffene please test this out and let me know if it fixes the issue with our 3-body, 1-dof Capytaine case. |
Collaborator
Yea it works now! Thanks! |
Contributor
Author
|
Hey @MShabara, let me know if this fix still works for you. Building off of your comment to me, I switched to use the length of |
Contributor
|
Hi @akeeste, the modification works for me, I tested the modifications and they work fine. I will go ahead and merge the pull request. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix PR to read Capytaine data when there are multiple bodies, each containing <6 DOF of hydrodynamic data
@jniffene see this one-line bugfix for our TEAMER project