Exclude R2020b and R2021a from Windows test runners #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akeeste
approved these changes
Nov 13, 2023
Contributor
Author
Contributor
|
@H0R5E what is being cached by setup-matlab? Is it saving a specific MATLAB installation for a future test? |
Contributor
Author
Yeah, that's the idea. It would reduce the installation time on subsequent runs. The caches are saved per repository, but the images are 4Gb-ish each, which means only 2 versions can be realistically cached, whereas we test about 10. |
Contributor
Author
Contributor
|
@H0R5E thanks for confirming. I agree; I don't see MATLAB caching being very useful right now, given their size. |
Contributor
Author
|
OK, I've removed the caching. Mathworks are looking at the issue with the broken versions already in #76. |
jtgrasb
added a commit
that referenced
this pull request
Dec 1, 2023
* Update gh-pages-redirect.html Added meta description to the website SEO Meta descriptions may be included in search results to concisely summarize page content. * Remove direct github installations (#1149) * Exclude R2020b and R2021a from Windows test runners (#1166) This commit excludes R2020b and R2021a from the Windows test runners. Specific changes are: + Merged windows and linux jobs, using the matrix to vary version differences + Excluded R2020b and R2021a from Windows jobs + Include latest in the Linux jobs * updating release notes doc * fix typo * updated most wecsim version --------- Co-authored-by: Mohamed Shabara <84589678+MShabara@users.noreply.github.com> Co-authored-by: Mathew Topper <damm_horse@yahoo.co.uk> Co-authored-by: jtgrasb <jtgrasb@sandia.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to exclude R2020b and R2021a from the Windows test runners while they seem to be broken.
Specific changes are:
EDIT: Opened bug report in
setup-matlab#76.