Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Aug 8, 2023

This is the major pull request coupling WEC-Sim and the MOST software package. Active developments before this PR is merged will go into the MOREnergyLab/WEC-Sim repository.

TODO list before release:

  • mooring lookup table block MOREnergylab/WEC-Sim#2
  • refactoring of windClass MOREnergylab/WEC-Sim#3
  • refactoring of windTurbineClass MOREnergylab/WEC-Sim#5
  • Create a set of MOST IO functions for a new pre-processing stage MOREnergylab/WEC-Sim#5
  • Expand and include documentation on MOST and its use MOREnergylab/WEC-Sim#1 (may be others)
  • Review by the larger WEC-Sim team @jtgrasb

TODO items outside of GitHub:

  • Draft publication statement on the new WEC-Sim+MOST capabilities
  • Ask MOST to track GitHub traffic (users, PRs, downloads, forks, stars, etc)
  • Set-up Google Analytics report specifically on the MOST subset of the documentation

@akeeste
Copy link
Contributor Author

akeeste commented Aug 23, 2023

@jtgrasb Do you have time to review the MOST implementation in the next couple of weeks? It would be great to get a second WEC-Sim reviewer here since it's such a big addition. I've done a lot of refactoring to standardize with WEC-Sim's conventions, but any other feedback on improved or faster implementation would be welcome.

They're not requirements before the next release, but it would also be great to add:

  • parameter validation for the windClass and windTurbineClass
  • visualization of the wind turbine in responseClass.saveViz

@jtgrasb
Copy link
Contributor

jtgrasb commented Aug 23, 2023

@akeeste Yeah, I should have some time in the next couple weeks. Look forward to checking it out!

@akeeste
Copy link
Contributor Author

akeeste commented Aug 24, 2023

@jtgrasb Great, thank you! My WEC-Sim/WEC-Sim_Applications#36 has a working WEC-Sim+MOST case. It's currently tracking my most branch, which should be pulled into MOREnergyLab dev soon. The .h5 file is not included yet, but can be copied from here for local runs.

@akeeste akeeste requested a review from jtgrasb August 24, 2023 15:44
@jtgrasb
Copy link
Contributor

jtgrasb commented Aug 28, 2023

@akeeste I noticed there's still a lot going on with this PR in terms of new commits. Should I wait until some of those changes are complete to review this?

@akeeste
Copy link
Contributor Author

akeeste commented Aug 28, 2023

@jtgrasb Since my latest PR was merged, it looks like the new commits are primarily documentation focused. So I don't think we need to wait. I'll follow-up at our Wednesday meeting

@kmruehl kmruehl added the MOST updates related to the MOST software label Sep 6, 2023
@jtgrasb jtgrasb marked this pull request as ready for review September 20, 2023 17:30
@jtgrasb
Copy link
Contributor

jtgrasb commented Sep 27, 2023

Thank you for all your hard work @MOREnergylab! This PR and the documentation is very well done. I will work on getting the mooring library block conflict resolved and merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MOST updates related to the MOST software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants