Skip to content

Conversation

@jleonqu
Copy link
Contributor

@jleonqu jleonqu commented May 23, 2023

This PR changes the 'type' property definition for PTO-Sim blocks. Now the 'type' property is similar to the waveClass 'type' property.

This is the new 'type' property definition:

type: This property must be defined to specify the type of block that will be used. The type value of each block is presented below:

type = 'electricGen' ---- Electric generator equivalent circuit
type = 'hydraulicCyl' ---- Hydraulic cylinder
type = 'hydraulicAcc' ---- Hydraulic accumulator
type = 'rectCheckValve' ---- Rectifying check valve
type = 'hydraulicMotor' ---- Hydraulic motor
type = 'linCrank' ---- Linear crank
type = 'adjustableRod' ---- Adjustable rod
type = 'checkValve' ---- Check valve
type = 'ddLinearGen' ---- Direct drive linear generator
type = 'ddRotaryGen' ---- Direct drive Rotary generator

@jleonqu jleonqu force-pushed the typePropertyPTOSim branch from f5f6688 to cd3281f Compare May 23, 2023 19:18
@kmruehl kmruehl self-requested a review May 31, 2023 14:35
@kmruehl kmruehl self-assigned this May 31, 2023
@kmruehl kmruehl requested a review from jtgrasb June 28, 2023 14:33
@jtgrasb
Copy link
Contributor

jtgrasb commented Jun 30, 2023

Just looked over this PR and the updates look good and running smoothly with the corresponding WEC-Sim Applications PR.

@kmruehl kmruehl added the PTO-Sim PTO-Sim (ptoSimClass.m) label Jul 10, 2023
@kmruehl
Copy link
Collaborator

kmruehl commented Jul 10, 2023

@jleonqu this looks good to me. I'm going to merge it, along with WEC-Sim/WEC-Sim_Applications#33

@kmruehl kmruehl merged commit 636eed5 into WEC-Sim:dev Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PTO-Sim PTO-Sim (ptoSimClass.m)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants