Updates to Morison Element Implementation #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2023 17:35
Updates to Morison Element Implementation to handle Directional Spreading. The current ME implementation allows for only one wave direction. The implemented changes should allow for wave directional spreading where the wave train can come from multiple directions.
The first library submitted was based off of the Master Branch of WEC-Sim and was missing the updates made to the body to account for the products of inertia. The required changes for morisonDirectionality was transferred to the latest body library in the Dev Branch.
kmruehl
requested changes
May 17, 2023
Collaborator
There was a problem hiding this comment.
I tested this case by running the tests on https://github.com/WEC-Sim/WEC-Sim_Applications/tree/master/Traditional_Morison_Element, and modifying the input file to include directional spreading
% Irregular Waves
waves = waveClass('irregular'); % Initialize Wave Class and Specify Type
waves.height = 2.0; % Significant Wave Height [m]
waves.period = 5.0; % Peak Period [s]
waves.spectrumType = 'PM'; % Specify Spectrum Type
waves.phaseSeed = 5;
waves.direction = [0,30,90]; % Wave Directionality [deg]
waves.spread = [0.1,0.2,0.7]; % Wave Directional Spreading [%}When I ran that case it showed that waves.spread was not being passed to the updated Body Block for the Irregular Morison Element. I updated the body block to include this input, and the case ran. I've uploaded my revisions, but it should get a second look. @nathanmtom can you review, and also test this case prior to merging?
ACTION @kmruehl
- update ME test case to include spreading, per example above
Collaborator
|
test added in WEC-Sim/WEC-Sim_Applications#32. Merging now. |
H0R5E
pushed a commit
to H0R5E/WEC-Sim
that referenced
this pull request
May 19, 2023
* Updates to Morison Element Implementation Updates to Morison Element Implementation to handle Directional Spreading. The current ME implementation allows for only one wave direction. The implemented changes should allow for wave directional spreading where the wave train can come from multiple directions. * Update WECSim_Lib_Body_Elements.slx The first library submitted was based off of the Master Branch of WEC-Sim and was missing the updates made to the body to account for the products of inertia. The required changes for morisonDirectionality was transferred to the latest body library in the Dev Branch. * adding missing waves.spread input to irregular morison element subsystem --------- Co-authored-by: kmruehl <kmruehl@sandia.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Morison Element Implementation to handle Directional Spreading. The current ME implementation allows for only one wave direction. The implemented changes should allow for wave directional spreading where the wave train can come from multiple directions.
Thank you to @munir-zarea who completed most of the updates through his internship with NREL.