Plot bemio features #1034
Plot bemio features #1034
Conversation
|
@jtgrasb Just a quick update here. I meant to review this PR last week, but did not. I'll put this back on my agenda for Wednesday/Thursday of this week. |
|
@jtgrasb Just letting you know that I begun reviewing this PR. I'll continue my review and provide additional feedback this week. Great work! |
akeeste
left a comment
There was a problem hiding this comment.
HI @jtgrasb
I added to my review here. Let me know your thoughts on those commented points. Most comments on plotAddedMass should apply to the other 5 plotting functions as well, but I condensed them into that file for simplicity
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
|
@akeeste Thanks for the detailed review! I think I've covered everything you mentioned except for one outstanding comment on the |
|
@jtgrasb Thanks Jeff! Sorry for the delay on resolving that one comment. Just responded, hopefully we can wrap up this PR this week. |
Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
* Update PlotAddedMass * test parser * Update tester * Add checks for bodies and dofs to plotAddedMass * Make individual dofs and bodies work * Add OSWEC data to test * Fix excitations * Add options to hydro structure * Update plotting functions * Remove testing scripts * Update source/functions/BEMIO/plotAddedMass.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update source/functions/BEMIO/checkAndFormatPlotVars.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * Update according to review * Update source/functions/BEMIO/formatPlot.m Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> --------- Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
This PR allows for different bodies, directions, and degrees of freedom to be specified in the hydro structures for BEMIO plotting.
Default settings for hydro.plotBodies (all bodies), hydro.plotDirections (first direction), and hydro.plotDofs (1,1; 3,3; 5,5) are added in the readBEM scripts. Then, the user can change the defaults and the plot BEMIO scripts will select the data based on desired plotting variables.