Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Apr 5, 2023

This PR adds a call in postProcess.m to the pre-existing bodyClass.storeForceAddedMass() function. This allows WEC-Sim to save the timeseries of the added mass force that is applied during the simulation.

This is necessary for a TEAMER award where the added mass force is varied during simulation. I'd like to change a couple other items in the added mass post-processing, but this is the least intrusive and most important for visualizing the current TEAMER work.

@akeeste akeeste added the Added Mass related to added mass label Apr 5, 2023
@akeeste akeeste requested a review from nathanmtom April 5, 2023 20:36
Copy link

@nathanmtom nathanmtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akeeste the first change file is related to updates made by a recent PR so no concerns. The modification to the postProcessWECSim is only adding an additional call during execution and this should not influence dynamic performance.

My only comment is that we should add some documentation in the developer section to illustrate how this postProcessing is being used to correct the addedmass force time history. Currently the advanced features developer section only describes the addedMass adjustment process. This does not need to be implemented in this PR but flagging as this book keeping is important to document to reduce future confusion.

@nathanmtom
Copy link

@akeeste Thanks for this PR, I approve and will let you merge when ready.

@akeeste akeeste self-assigned this Apr 6, 2023
@akeeste
Copy link
Contributor Author

akeeste commented Apr 6, 2023

@nathanmtom Thanks for your quick review. I removed the extraneous file and added a project card for myself to expand the developer docs on our post processing corrections.

@akeeste akeeste merged commit b3f56bc into WEC-Sim:dev Apr 6, 2023
@akeeste akeeste deleted the umdItems branch April 6, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added Mass related to added mass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants