Remove 'fixed' mass option from OSWEC input file #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmtom
approved these changes
Apr 5, 2023
nathanmtom
left a comment
There was a problem hiding this comment.
@jtgrasb Thanks for catching this bug. I've confirmed the issue using the 'Dev' branch and approve this pull request to solve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where the 'fixed' mass option was still being used for the OSWEC case, causing it to give errors when trying to run. This is only an issue in the dev branch.
The 'fixed' mass option was removed with PR #856, but the input file to the OSWEC was changed back with this commit. This PR simply removes the 'fixed' mass and sets the mass and inertia equal to 999.