Remove fixed mass option #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmruehl
approved these changes
Jul 1, 2022
Collaborator
kmruehl
left a comment
There was a problem hiding this comment.
This looks good. Making a minor change to the doc, then I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project card
The bodyClass fixed mass option can be somewhat misleading if there is not actually a fixed constraint. If the body isn't fixed it will likely sink indefinitely and become unphysical. Also, if a fixed constraint is connected to the body,
body.mass='fixed'is not required and its mass doesn't affect the simulation.This PR removes the
body.mass='fixed'option, the associated logic, and a small related section in the documentation. For after v5.0