Control applications docs #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleonqu
reviewed
Apr 24, 2023
Contributor
jleonqu
left a comment
There was a problem hiding this comment.
I've made a couple of comments on the documentation. This is a well written section that is easy to read and follow. I have compiled the documentation and everything looks good on my end.
Since you are presenting the equations for the different controllers, I would suggest adding some references for the theory and the equations.
Contributor
Author
|
@jleonqu Thanks for the comments! I've updated the docs accordingly and added references. |
Contributor
|
I've checked the updates and everything looks good. This is ready to merge to the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docs to include documentation about the control applications cases applied in PR #30 on the WEC-Sim Applications repo.