[test] Test more alignment for load extend and splat ops#251
Merged
AndrewScheidecker merged 2 commits intoWAVM:masterfrom Jan 16, 2020
Merged
[test] Test more alignment for load extend and splat ops#251AndrewScheidecker merged 2 commits intoWAVM:masterfrom
AndrewScheidecker merged 2 commits intoWAVM:masterfrom
Conversation
Contributor
Author
|
@AndrewScheidecker, @tlively, PTAL, thanks! |
AndrewScheidecker
approved these changes
Jan 10, 2020
AndrewScheidecker
requested changes
Jan 15, 2020
Member
AndrewScheidecker
left a comment
There was a problem hiding this comment.
Sorry, missed some typos in my initial review
| @@ -1,116 +1,307 @@ | |||
| ;; Vaild alignment (align=1, 2, 4, 8, 16) | |||
Test/spec/simd/simd_align.wast
Outdated
| ) | ||
| (assert_malformed | ||
| (module quote | ||
| "(memroy 1) (func (result v128) (i16x8.load8x8_s align=-1 (i32.const 0)))" |
Member
There was a problem hiding this comment.
s/memroy/memory here and elsewhere in the file
tlively
approved these changes
Jan 16, 2020
Test/spec/simd/simd_align.wast
Outdated
| (assert_return (invoke "v128_aligned_read_and_write") (v128.const i16x8 0 1 2 3 4 5 6 7)) | ||
| (assert_return (invoke "v128_aligned_read_and_unalign_write") (v128.const i32x4 0 1 2 3)) | ||
| (assert_return (invoke "v128_unalign_read_and_aligned_write") (v128.const i32x4 0 1 2 3)) | ||
| (assert_return (invoke "v128_unalign_read_and_aligned_write") (v128.const i32x4 0 1 2 3)) No newline at end of file |
There was a problem hiding this comment.
Not from this PR, but "unalign" in this name should be "unaligned" as well.
Contributor
Author
|
@tlively, @AndrewScheidecker, thanks for catching these stupid typos, all fixed. |
Member
|
LGTM, thanks! |
Honry
added a commit
to Honry/simd
that referenced
this pull request
Jan 17, 2020
Tests are synced from WAVM/WAVM#251
tlively
pushed a commit
to WebAssembly/simd
that referenced
this pull request
Jan 17, 2020
Tests are synced from WAVM/WAVM#251
kenohassler
pushed a commit
to fgsect/WAFL
that referenced
this pull request
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.