Removing and fixing imports and other warnings#1
Closed
Vlix wants to merge 20 commits intoavoid-warnings-with-CPPfrom
Closed
Removing and fixing imports and other warnings#1Vlix wants to merge 20 commits intoavoid-warnings-with-CPPfrom
Vlix wants to merge 20 commits intoavoid-warnings-with-CPPfrom
Conversation
c9d339d to
43d6514
Compare
Mostly found all the imports of 'Data.Monoid' and 'Data.Semigroup' and removed as much as I can without breaking it. Used CPP for backwards compatibility where needed. Thought about using CPP to avoid deprecation warning of 'parseMonad', but defining a helper function seemed way more straightforward.
- removed useless imports - tried to avoid incomplete-uni-patterns with explicit 'error' calls for better error messages - suppress warnings in tests - add 'TypeOperator' pragma for type equality (~) usage - few other things
…ances of 'FormResult' and 'AForm', while staying compatible with 'base >= 4.10'
556775a to
065a5be
Compare
Owner
Author
|
This PR is also ready to review as it is rebased on top of the tweaked yesodweb#1876 |
Owner
Author
|
Ran a few more builds with extra warning flags and |
Vlix
commented
Jun 15, 2025
| {-# LANGUAGE TemplateHaskell #-} | ||
| {-# LANGUAGE TypeFamilies #-} | ||
|
|
||
| import Yesod.Core |
Owner
Author
There was a problem hiding this comment.
Was removed erroneously in the first batch of pragma orderings
* lots of CPP and cleanup of 'Data.Monoid/Semigroup' stuff Mostly found all the imports of 'Data.Monoid' and 'Data.Semigroup' and removed as much as I can without breaking it. Used CPP for backwards compatibility where needed. Thought about using CPP to avoid deprecation warning of 'parseMonad', but defining a helper function seemed way more straightforward. * yesod-core: found a better solution with 'defaultRequest' * removed a bunch of pragmas that weren't used * removal of Semigroup stuff outside of libraries * bump to 'base >= 4.11' on libraries that had Semigroup imports (and remove the imports)
|
I think you want to chage the target repository :) |
Owner
Author
|
Reopened on yesodweb#1877 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last part of yesodweb#1862