Skip to content

build fixes for mingw#65

Merged
Vizonex merged 1 commit intoVizonex:mainfrom
totaam:mingw
Jul 28, 2025
Merged

build fixes for mingw#65
Vizonex merged 1 commit intoVizonex:mainfrom
totaam:mingw

Conversation

@totaam
Copy link
Contributor

@totaam totaam commented Jul 28, 2025

  • enable use_system_libuv by default on mingw,
  • mingw toolchain expects gcc style linker arguments: -lLIB,
  • use explicit casts to avoid makes integer from pointer without a cast errors

Supersedes #60

Note: this is unrelated to #64 which broke separately.

* enable use_system_libuv by default on mingw,
* mingw toolchain expects gcc style linker arguments: '-lLIB',
* use explicit casts to avoid 'makes integer from pointer without a cast' errors
@Vizonex
Copy link
Owner

Vizonex commented Jul 28, 2025

@totaam Sorry if I made many changes while you were waiting. There were just some things left over from the original uvloop library that I felt needed to be cherry-picked to optimize execution.

@Vizonex
Copy link
Owner

Vizonex commented Jul 28, 2025

@totaam I'll let this one pass since The only test screwing up was on asyncio's end instead of a winloop-test. As long as the wheels appropriately build with the MSVC Compiler I'll let it pass. It just needs to complete. I really need to go in and work on a making a system for the tests and add labels to ignore certain things when standard-asyncio is in use since I am not willing to spend my time writing a handful of wrappers with super().func(...) attached to everything.

@Vizonex
Copy link
Owner

Vizonex commented Jul 28, 2025

@totaam Congrats I'm going to now pass this off since it works correctly.

@Vizonex Vizonex merged commit 8f72179 into Vizonex:main Jul 28, 2025
11 of 12 checks passed
@Vizonex Vizonex mentioned this pull request Jul 28, 2025
@totaam
Copy link
Contributor Author

totaam commented Sep 24, 2025

@Vizonex FYI winloop is now available as a binary package via MSYS2: msys2/MINGW-packages#25643

$ pacman -Ss winloop
clangarm64/mingw-w64-clang-aarch64-python-winloop 0.2.2-1
    An alternative library for uvloop compatibility with MS Windows
mingw64/mingw-w64-x86_64-python-winloop 0.2.2-1
    An alternative library for uvloop compatibility with MS Windows
ucrt64/mingw-w64-ucrt-x86_64-python-winloop 0.2.2-1
    An alternative library for uvloop compatibility with MS Windows
clang64/mingw-w64-clang-x86_64-python-winloop 0.2.2-1
    An alternative library for uvloop compatibility with MS Windows

And it can be installed with just pacman -S mingw-w64-x86_64-python-winloop
Also tested on aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants