building on MSYS2 by totaam · Pull Request #60 · Vizonex/Winloop

totaam · 2025-07-21T15:49:45Z

No description provided.

Vizonex · 2025-07-21T15:53:37Z

_ No description provided. _

be sure to put down -'fixes #60' in the first comment description, so that the issue automatically closes out. Other than that, thanks for opening :)

Vizonex · 2025-07-21T16:02:26Z

@totaam The workflows will help. They all use msvc by default so this way if they fail you'll be able to figure out why.

totaam · 2025-07-21T16:06:07Z

This PR can't work as it is, so it's no surprise that the checks fail.
FWIW: you could easily build on MSYS2: https://github.com/msys2/setup-msys2

Vizonex · 2025-07-21T16:10:22Z

This PR can't work as it is, so it's no surprise that the checks fail. FWIW: you could easily build on MSYS2: https://github.com/msys2/setup-msys2

It's ok I'm offering code suggestions to help you :)

Vizonex · 2025-07-21T16:00:06Z

setup.py

@@ -250,19 +250,16 @@ def build_extensions(self):
                "winloop/loop.pyx"
            ],
            include_dirs=[


Suggested change

include_dirs=[

if not ('GCC' in sys.version):

include_dirs=[

"vendor/libuv/src",

"vendor/libuv/src/win",

"vendor/libuv/include"

]

We need to remember to retain compatibility with MSVC. This should be a start...

Vizonex · 2025-07-21T16:06:13Z

setup.py

-                "vendor/libuv/src/win",
-                "vendor/libuv/include"
            ],
            extra_link_args=[  # subset of libuv Windows libraries


Suggested change

extra_link_args=[ # subset of libuv Windows libraries

extra_link_args=[ # subset of libuv Windows libraries

"Shell32.lib",

"Ws2_32.lib",

"Advapi32.lib",

"iphlpapi.lib",

"Userenv.lib",

"User32.lib",

"Dbghelp.lib",

"Ole32.lib"

] if not ('GCC' in sys.version) else [

"-lShell32",

"-lWs2_32",

"-lAdvapi32",

"-liphlpapi",

"-lUserenv",

"-lUser32",

"-lDbghelp",

"-lOle32",

]

This should help.

Vizonex · 2025-07-21T16:08:10Z

winloop/loop.pyx

    def _get_backend_id(self):
        """This method is used by uvloop tests and is not part of the API."""
-        return uv.uv_backend_fd(self.uvloop)
+        return int(<uintptr_t> uv.uv_backend_fd(<uv.uv_loop_t*> self.uvloop))


Suggested change

return int(<uintptr_t> uv.uv_backend_fd(<uv.uv_loop_t*> self.uvloop))

return int(<uintptr_t> uv.uv_backend_fd(self.uvloop))

Not sure if recasting self.uvloop is a good idea. it's already defined as uv.uv_loop_t* in the pxd file. But I appreciate your attempt.

You're right, this part is not needed.

And neither was the re-definition of uv.pipe_t via a cdef extern.

Vizonex · 2025-07-21T16:14:48Z

setup.py

    def initialize_options(self):
        super().initialize_options()
-        self.use_system_libuv = False
+        self.use_system_libuv = True


I don't think we need this line to be flipped to True since there should be a compiler argument that does that.

Sure, I only did this because I have absolutely no idea how to toggle it any other way.
./setup.py --with-use-system-libyuv, or any reasonable argument I tried. How does it work?

Vizonex · 2025-07-25T16:49:19Z

@totaam You'll want to merge your branch with some of the upcoming changes I made to winloop I left a few changes you could make to make mysys support happen

totaam · 2025-07-28T16:02:35Z

For future reference, this was one of the compilation errors:

winloop/loop.c:113295:104: error: passing argument 2 of 'uv_pipe_open' makes integer from pointer without a cast [-Wint-conversion]
113295 |   __pyx_v_err = uv_pipe_open(((uv_pipe_t *)__pyx_v_handle->__pyx_base.__pyx_base.__pyx_base._handle), ((uv_os_fd_t)__pyx_v_fd));
       |                                                                                                       ~^~~~~~~~~~~~~~~~~~~~~~~
       |                                                                                                        |
       |                                                                                                        void *

I will open a clean new PR.

totaam mentioned this pull request Jul 21, 2025

building on MSYS2 #59

Closed

Vizonex self-requested a review July 21, 2025 15:52

Vizonex reviewed Jul 22, 2025

View reviewed changes

totaam closed this Jul 28, 2025

totaam force-pushed the main branch from 4533ab5 to 43c0d54 Compare July 28, 2025 15:34

totaam mentioned this pull request Jul 28, 2025

build fixes for mingw #65

Merged

-            extra_link_args=[  # subset of libuv Windows libraries
+            extra_link_args=[  # subset of libuv Windows libraries
+                "Shell32.lib",
+                "Ws2_32.lib",
+                "Advapi32.lib",
+                "iphlpapi.lib",
+                "Userenv.lib",
+                "User32.lib",
+                "Dbghelp.lib",
+                "Ole32.lib"
+                ] if not ('GCC' in sys.version) else [
+                "-lShell32",
+                "-lWs2_32",
+                "-lAdvapi32",
+                "-liphlpapi",
+                "-lUserenv",
+                "-lUser32",
+                "-lDbghelp",
+                "-lOle32",
+                ]

	return int(<uintptr_t> uv.uv_backend_fd(<uv.uv_loop_t*> self.uvloop))
	return int(<uintptr_t> uv.uv_backend_fd(self.uvloop))

Conversation

totaam commented Jul 21, 2025

Uh oh!

Vizonex commented Jul 21, 2025

Uh oh!

Vizonex commented Jul 21, 2025

Uh oh!

totaam commented Jul 21, 2025

Uh oh!

Vizonex commented Jul 21, 2025

Uh oh!

Vizonex Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Vizonex Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Vizonex Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

totaam Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

totaam Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Vizonex Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

totaam Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Vizonex commented Jul 25, 2025

Uh oh!

totaam commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants