Update section on form_for compatibility#1644
Merged
joelhawksley merged 12 commits intoViewComponent:mainfrom Feb 13, 2023
Merged
Update section on form_for compatibility#1644joelhawksley merged 12 commits intoViewComponent:mainfrom
joelhawksley merged 12 commits intoViewComponent:mainfrom
Conversation
Spone
reviewed
Jan 29, 2023
Collaborator
|
Thanks for taking a stab at this! |
camertron
requested changes
Jan 31, 2023
ianterrell
reviewed
Jan 31, 2023
camertron
reviewed
Feb 2, 2023
Contributor
There was a problem hiding this comment.
Alright I'm cool with this change, although I wonder if it's obviated by @BlakeWilliams' timely PR. At the very least I think we should include the new CaptureCompatibility module in the list when the PR gets merged.
Spone
reviewed
Feb 2, 2023
joelhawksley
reviewed
Feb 2, 2023
Member
joelhawksley
left a comment
There was a problem hiding this comment.
👋🏻 Just some grammar and voicing edits to keep the docs cohesive. Happy to re-edit if material changes are requested.
camertron
approved these changes
Feb 9, 2023
Contributor
|
Hey @tmaier, could you resolve that merge conflict? As soon as that's done, I'll merge this in 😎 |
Fix prose errors Fix pose errors Fix markdown lint error MD007
Update docs/CHANGELOG.md Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
Co-authored-by: Joel Hawksley <joelhawksley@github.com>
default way / classic way / the way how originally intended in Ruby on Rails land
Contributor
Author
|
@camertron done |
Contributor
|
@tmaier sorry for the churn here. Looks like there's another conflict now 🤦 |
joelhawksley
approved these changes
Feb 13, 2023
tmaier
added a commit
to tmaier/view_component
that referenced
this pull request
Mar 7, 2023
joelhawksley
added a commit
that referenced
this pull request
Mar 8, 2023
…1674) * Add capture_compatibility_patch_enabled as option Related to #1650 and #1644 * Update CHANGELOG.md * Update docs/known_issues.md * Update docs/known_issues.md * reorder item * make test more flexible to account for change in rails main --------- Co-authored-by: Joel Hawksley <joelhawksley@github.com> Co-authored-by: Joel Hawksley <joel@hawksley.org>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
* Update section on form_for compatibility Fix prose errors Fix pose errors Fix markdown lint error MD007 * Update CHANGELOG.md Update docs/CHANGELOG.md Co-authored-by: Cameron Dutro <camertron@gmail.com> * Update docs/known_issues.md Co-authored-by: Cameron Dutro <camertron@gmail.com> * Update options * Move section up so that all FormBuilder related is together * Be more specific about the issue * Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> * Elaborate on "classic" FormBuilder * Apply suggestions from code review Co-authored-by: Joel Hawksley <joelhawksley@github.com> * Fix statement default way / classic way / the way how originally intended in Ruby on Rails land * Apply suggestions from code review --------- Co-authored-by: Cameron Dutro <camertron@gmail.com> Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Co-authored-by: Joel Hawksley <joelhawksley@github.com> Co-authored-by: Joel Hawksley <joel@hawksley.org>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…iewComponent#1674) * Add capture_compatibility_patch_enabled as option Related to ViewComponent#1650 and ViewComponent#1644 * Update CHANGELOG.md * Update docs/known_issues.md * Update docs/known_issues.md * reorder item * make test more flexible to account for change in rails main --------- Co-authored-by: Joel Hawksley <joelhawksley@github.com> Co-authored-by: Joel Hawksley <joel@hawksley.org>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
* Update section on form_for compatibility Fix prose errors Fix pose errors Fix markdown lint error MD007 * Update CHANGELOG.md Update docs/CHANGELOG.md Co-authored-by: Cameron Dutro <camertron@gmail.com> * Update docs/known_issues.md Co-authored-by: Cameron Dutro <camertron@gmail.com> * Update options * Move section up so that all FormBuilder related is together * Be more specific about the issue * Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Update docs/known_issues.md Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> * Elaborate on "classic" FormBuilder * Apply suggestions from code review Co-authored-by: Joel Hawksley <joelhawksley@github.com> * Fix statement default way / classic way / the way how originally intended in Ruby on Rails land * Apply suggestions from code review --------- Co-authored-by: Cameron Dutro <camertron@gmail.com> Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Co-authored-by: Joel Hawksley <joelhawksley@github.com> Co-authored-by: Joel Hawksley <joel@hawksley.org>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…iewComponent#1674) * Add capture_compatibility_patch_enabled as option Related to ViewComponent#1650 and ViewComponent#1644 * Update CHANGELOG.md * Update docs/known_issues.md * Update docs/known_issues.md * reorder item * make test more flexible to account for change in rails main --------- Co-authored-by: Joel Hawksley <joelhawksley@github.com> Co-authored-by: Joel Hawksley <joel@hawksley.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I think it helps people when they know what the compatibility issues between
form_forand ViewComponents actually mean and what options they have.#241
What approach did you choose and why?
I wanted to keep the section small, but mention all options known so far.
It does not seek to create a dedicated page on this particular topic, like #946 tried.