Merged
Conversation
Collaborator
Author
boardfish
approved these changes
Jan 4, 2022
Collaborator
boardfish
left a comment
There was a problem hiding this comment.
Looks good to me. Am I right in saying this would help to resolve the issue I'm facing in #1227 where we should only use turbo-rails for Rails versions greater than 5? I suppose I'd add them to Appraisals, right?
You might also want to add Appraisals and the gemfiles folder to your section under CODEOWNERS.
Co-authored-by: Simon Fish <si@mon.fish>
Collaborator
Author
Yes, exactly!
Will do. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This sets up Appraisal in order to facilitate testing multiple Rails versions.
Other Information
This has been decided here: #1098 (comment) and will allow conditional dependencies (required for Tailwind support, see #1098)