Skip to content

Fix ruby 3.0 CI#1224

Merged
BlakeWilliams merged 6 commits intomainfrom
fix-ruby3-ci
Jan 3, 2022
Merged

Fix ruby 3.0 CI#1224
BlakeWilliams merged 6 commits intomainfrom
fix-ruby3-ci

Conversation

@Spone
Copy link
Collaborator

@Spone Spone commented Dec 30, 2021

Summary

This closes #1223 as suggested by #1223 (comment)

Other Information

This also bumps all Rails versions to the latest patch release for each supported minor version.

@Spone Spone requested a review from a team as a code owner December 30, 2021 14:45
@Spone Spone self-assigned this Dec 30, 2021
@edwinthinks
Copy link
Contributor

Looks good to me! Thanks @Spone for this.

@Spone
Copy link
Collaborator Author

Spone commented Dec 30, 2021

Waiting for a review to merge :)

This was referenced Dec 30, 2021
@Spone
Copy link
Collaborator Author

Spone commented Jan 3, 2022

@boardfish would you mind reviewing this? Weirdly, I can't add you as a reviewer...

Spone and others added 2 commits January 3, 2022 16:40
Co-authored-by: Simon Fish <si@mon.fish>
Co-authored-by: Simon Fish <si@mon.fish>
@Spone Spone enabled auto-merge (squash) January 3, 2022 15:41
@Spone Spone disabled auto-merge January 3, 2022 15:42
@Spone
Copy link
Collaborator Author

Spone commented Jan 3, 2022

There a "11 expected checks" that are obsolete since they have been renamed, but they remain in the "required" checks. Their updated versions pass correctly.

@BlakeWilliams Can you force-merge this?

@BlakeWilliams BlakeWilliams merged commit 573f39f into main Jan 3, 2022
@BlakeWilliams BlakeWilliams deleted the fix-ruby3-ci branch January 3, 2022 17:12
@BlakeWilliams
Copy link
Contributor

Done, thanks for fixing this up!

@Spone
Copy link
Collaborator Author

Spone commented Jan 3, 2022

Thanks @BlakeWilliams! I'm afraid we will have the same issue on all pending PRs. Do you know if there's a way to reinitialize the list of required checks repository-wide?

@BlakeWilliams
Copy link
Contributor

@Spone It looks like it's due to older versions of Rails/Ruby being marked as required builds individually as opposed to all test builds being marked as required. I went ahead and removed the required checks that depended on older versions of Rails and added the new versions as required checks.

I think that may solve it for now and an empty commit or rebase may fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI tests are failing on test runs in Rails 6.1.3.1 & Ruby 3

4 participants