Conversation
|
Looks good to me! Thanks @Spone for this. |
|
Waiting for a review to merge :) |
|
@boardfish would you mind reviewing this? Weirdly, I can't add you as a reviewer... |
Co-authored-by: Simon Fish <si@mon.fish>
Co-authored-by: Simon Fish <si@mon.fish>
|
There a "11 expected checks" that are obsolete since they have been renamed, but they remain in the "required" checks. Their updated versions pass correctly. @BlakeWilliams Can you force-merge this? |
|
Done, thanks for fixing this up! |
|
Thanks @BlakeWilliams! I'm afraid we will have the same issue on all pending PRs. Do you know if there's a way to reinitialize the list of required checks repository-wide? |
|
@Spone It looks like it's due to older versions of Rails/Ruby being marked as required builds individually as opposed to all test builds being marked as required. I went ahead and removed the required checks that depended on older versions of Rails and added the new versions as required checks. I think that may solve it for now and an empty commit or rebase may fix it. |
Summary
This closes #1223 as suggested by #1223 (comment)
Other Information
This also bumps all Rails versions to the latest patch release for each supported minor version.