undo IsZero check for PVC storage size#1928
Merged
AndrewChubatiuk merged 1 commit intomasterfrom Mar 4, 2026
Merged
Conversation
vrutkovs
approved these changes
Mar 4, 2026
AndrewChubatiuk
added a commit
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expected isZero covers nil, but it doesn't, reverting this change
Summary by cubic
Switch PVC storage size check from IsZero() to a nil check. Prevents a nil dereference and safely skips PVC updates when storage requests are missing.
Written for commit e3b21a5. Summary will update on new commits.