Conversation
… or relabelling is set in ingestOnly mode
Contributor
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:28">
P1: Custom agent: **Changelog Review Agent**
This changelog item does not meet the required user-centric structure: it states only the new behavior, but omits an explicit before/now/user-visible impact explanation required by the rule’s mandatory section 3.</violation>
<violation number="2" location="docs/CHANGELOG.md:28">
P3: Fix typo and grammar in the changelog entry to keep release notes clear and professional.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
…mode Signed-off-by: Andrii Chubatiuk <achubatiuk@victoriametrics.com>
vrutkovs
approved these changes
Mar 4, 2026
AndrewChubatiuk
added a commit
that referenced
this pull request
Mar 4, 2026
… or relabelling is set in ingestOnly mode (#1926) Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Stop mounting the scrape config secret for vmagent and vmsingle in ingest-only mode, even when relabeling or stream aggregation is enabled. This avoids unexpected secret mounts and RBAC/startup failures (see #1828).
Written for commit 940874a. Summary will update on new commits.