Skip to content

vmpodscrape: fixed vmpodscrape port for vlagent and vmagent#1888

Merged
vrutkovs merged 2 commits intomasterfrom
vmpodscrape-port-fix
Feb 26, 2026
Merged

vmpodscrape: fixed vmpodscrape port for vlagent and vmagent#1888
vrutkovs merged 2 commits intomasterfrom
vmpodscrape-port-fix

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Feb 26, 2026

fixes #1887


Summary by cubic

Fixes VMPodScrape port for VLAgent and VMAgent so self-scraping targets the correct HTTP port. Also unifies scrape reconciliation and naming. Fixes #1887.

  • Bug Fixes

    • VMPodScrape now takes an explicit port; use http for VMAgent/VLAgent and monitoring-http for VMAnomaly.
    • Changelog updated to document the fix.
  • Refactors

    • Introduced reconcile.VMPodScrape with consistent update logic and diff logging; removed VMPodScrapeForCRD.
    • Renamed VMServiceScrapeForCRD to VMServiceScrape and updated all callers.

Written for commit 16b8a29. Summary will update on new commits.

@AndrewChubatiuk AndrewChubatiuk changed the title vmpodscrape: fixed vmporscrape port for vlagent and vmagent vmpodscrape: fixed vmpodscrape port for vlagent and vmagent Feb 26, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 24 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:21">
P2: Custom agent: **Changelog Review Agent**

Changelog entry does not include the required before/after user-centric explanation of the visible impact (only says “fixed”), which violates the rule’s mandatory structure.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
@vrutkovs vrutkovs merged commit baf42d7 into master Feb 26, 2026
7 checks passed
@vrutkovs vrutkovs deleted the vmpodscrape-port-fix branch February 26, 2026 10:18
vrutkovs pushed a commit that referenced this pull request Mar 3, 2026
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
AndrewChubatiuk added a commit that referenced this pull request Mar 3, 2026
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
vrutkovs added a commit that referenced this pull request Mar 4, 2026
Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
Co-authored-by: Andrii Chubatiuk <achubatiuk@victoriametrics.com>
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
fixed vmpodscrape port for vlagent and vmagent (#1888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VLAgent: Missing port name monitoring-http

2 participants