deps: unpin AWS dependencies and add workaround for S3 compatibility#9844
Merged
deps: unpin AWS dependencies and add workaround for S3 compatibility#9844
Conversation
makasim
reviewed
Oct 9, 2025
go.mod
Outdated
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.13.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.6.2 | ||
| github.com/VictoriaMetrics/VictoriaLogs v0.0.0-20250728123024-98593029b5aa | ||
| github.com/VictoriaMetrics/VictoriaLogs v1.36.1 |
Member
There was a problem hiding this comment.
We should use commit as the version according to contributing doc.
For VictoriaMetrics packages, use go get <dependency>@canonical_commit_hash. Finally, run go mod tidy and go mod vendor to update go.mod, go.sum, and /vendor.
Member
Author
There was a problem hiding this comment.
I guess we also need to update make targets to reflect that as commit hash was overriden by make vendor-update.
Reverting this manually in the meantime
d6e64a3 to
896905a
Compare
74fe2bd to
a4cda3f
Compare
896905a to
09f1916
Compare
makasim
approved these changes
Oct 9, 2025
09f1916 to
812e754
Compare
zekker6
added a commit
that referenced
this pull request
Oct 10, 2025
…9844) Updates: - unpin AWS dependencies and run `make vendor-update` - add config options to enable checksums only if required by storage in order to preserve backwards compatibility Related issues: - #9748 - #8622 Tested with: AWS S3, self-hosted MinIO, Linode object storage as it was failing previously with multi-part uploads (reported here - #8630 (comment)). An updated library allows (PR with the fix - aws/aws-sdk-go-v2#3151) overriding multi-part upload configurations so that compatibility can be preserved. Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates:
make vendor-updateRelated issues:
Tested with: AWS S3, self-hosted MinIO, Linode object storage as it was failing previously with multi-part uploads (reported here - #8630 (comment)).
An updated library allows (PR with the fix) overriding multi-part upload configurations so that compatibility can be preserved.
Note before merge: this PR targets another branch with an updated Go version since VictoriaLogs updated requirements to Go version and
make vendor-updatewas failing due to version mismatch. Base for this PR will be moved to master once current base branch will be merged into master.