encoder-ffmpeg.cpp: Remove legacy API usage#783
Merged
Conversation
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API. It would only make sense to use av_codec_next() if FF_API_NEXT is still defined, so I flipped the condition on the preprocessor statement.
Contributor
|
I think it makes more sense to completely remove the deprecated path entirely. The minimum FFmpeg version for StreamFX was always 4.2, which already has |
Xaymar
approved these changes
Feb 24, 2022
Xaymar
pushed a commit
that referenced
this pull request
Feb 26, 2022
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
Xaymar
pushed a commit
that referenced
this pull request
Feb 26, 2022
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
Xaymar
pushed a commit
that referenced
this pull request
Feb 26, 2022
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
Xaymar
pushed a commit
that referenced
this pull request
Mar 27, 2023
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
Xaymar
pushed a commit
that referenced
this pull request
Mar 28, 2023
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
Xaymar
pushed a commit
that referenced
this pull request
Mar 28, 2023
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
Xaymar
pushed a commit
that referenced
this pull request
Apr 5, 2023
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
Xaymar
pushed a commit
that referenced
this pull request
Apr 5, 2023
The build breaks if compiling against a newer version of ffmpeg which does not define the FF_API_NEXT macro and has fully removed the av_codec_next() API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
The build breaks if compiling against newer versions of ffmpeg which do not define the FF_API_NEXT macro and have fully removed the av_codec_next() API. It would only make sense to use av_codec_next() if FF_API_NEXT is still defined, so I flipped the condition on the preprocessor statement.
From what it seems, this could be a latent bug. I'm not too familiar with how the CI/CD on this repo works, but depending on the version of ffmpeg it sources, this issue could show up in builds in the future.
Checklist