libvesktop: native dbus module#1180
Merged
Merged
Conversation
Vendicated
commented
Oct 1, 2025
This was referenced Oct 3, 2025
This was referenced Oct 5, 2025
Open
Member
Author
Member
Author
|
also if you just want the tray badge, you shouldn't need this PR for that, building from main should work fine! I added it in my other PR (#1179). This pr just improves taskbar / dock badge compatibility |
|
Then why #298 is still open and is being closed by this PR? |
Member
Author
|
that issue is about the dock/taskbar icon, not the tray. these are two separate things! |
|
Are they though? The title doesn't specify where the badge is not working, I also don't know when it supposedly got fixed on main branch, and I couldn't find a closed issue about it. I guess it was fixed very recently? Because I did update my system on 11th of August, the previous time. And it was still broken, obviously. I guess somewhere after the new icon was added? |
Andrew15-5
reviewed
Oct 7, 2025
Creationsss
pushed a commit
to Creationsss/Vesktop
that referenced
this pull request
Oct 16, 2025
Both setAppBadge and autoStart at system boot now use dbus calls. This means that autoStart will work in Flatpak
13 tasks
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #273 #298 #424
This adds a
libvesktopC++ native node addon for dbus messaging. It uses gdbus because it's much saner than normal dbus and chromium depends on GTK anyway.Both setAppBadge and autoStart at system boot now use dbus calls and both work fine for me.
Interface
How to test
Just run the app like normal, prebuilds will be used (see below)
Packaging
By default, prebuilds are used. These are included in this repo for simplicity (it's just two ~60kb binaries so not that bad). Users can build from source by running
pnpm buildLibVesktopbefore building or running Vesktop