Skip to content

fix(chat): execution graph status error#903

Merged
hazeone merged 3 commits intomainfrom
fix/chat_status_error
Apr 24, 2026
Merged

fix(chat): execution graph status error#903
hazeone merged 3 commits intomainfrom
fix/chat_status_error

Conversation

@hazeone
Copy link
Copy Markdown
Contributor

@hazeone hazeone commented Apr 23, 2026

refactor(chat): remove thinking section from ChatMessage component an…
feat(chat): add suppressThinking flag to control visibility of the tr…

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other

Validation

Checklist

  • I ran relevant checks/tests locally.
  • I updated docs if behavior or interfaces changed.
  • I verified there are no unrelated changes in this PR.

hazeone added 2 commits April 23, 2026 20:41
…d update related logic for rendering messages
…ailing "thinking..." indicator in the chat component
@hazeone hazeone marked this pull request as ready for review April 23, 2026 13:11
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 602797a374

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/Chat/index.tsx
Comment on lines +461 to +463
const streamIsInGraph =
isLatestOpenRun && streamingReplyText == null && hasAnyStreamContent;
const suppressThinking = streamIsInGraph;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep trailing thinking visible when stream has no live step

streamIsInGraph is derived from hasAnyStreamContent, which is true even when streamingTools only contains completed entries. After a tool_result final event, streamingMessage is cleared but completed tool statuses are retained, so this condition suppresses the trailing "Thinking..." row while the run is still active (sending/pendingFinal). In that gap there is no live in-graph step, so hiding the indicator regresses liveness feedback and makes the execution graph look idle mid-run.

Useful? React with 👍 / 👎.

@hazeone hazeone merged commit 42a26c4 into main Apr 24, 2026
12 checks passed
@hazeone hazeone deleted the fix/chat_status_error branch April 24, 2026 02:03
DigitalNomad-Chat added a commit to DigitalNomad-Chat/ClawX that referenced this pull request Apr 26, 2026
… dedupe (ValueCell-ai#821 ValueCell-ai#845 ValueCell-ai#870 ValueCell-ai#873 ValueCell-ai#875 ValueCell-ai#878 ValueCell-ai#880 ValueCell-ai#885 ValueCell-ai#886 ValueCell-ai#887 ValueCell-ai#891 ValueCell-ai#903)

Overhaul execution graph card (collapse/expand, narration steps, web_fetch links),
separate thinking messages, render LaTeX math, dedupe optimistic messages,
hide recoverable gateway timeouts, add startup history recovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant