Implement '' and ``. #1993
Merged
Implement '' and ``. #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is currently untested, pending acceptance of upstream patch. |
avindra
approved these changes
Sep 2, 2017
Member
|
@brandonbloom Sorry, what's the difference between |
Contributor
Author
|
The difference is what happens f you execute the command twice in a row. Instead of going back, then back again, it goes back, then forward, alternating back and forth. Very useful for comparing things at distinct points the same file quickly: just hit tick or single-quote over and over again to flip back and forth. |
This was referenced Sep 4, 2017
Member
|
Nice job on the two repo attack here! It is pretty cool when your change gets merged into vscode and here and then the next release makes you happier :) |
Member
|
@brandonbloom Awesome! Nice job! Could you add some tests for this feature? |
Contributor
Author
|
Are there any tests for CommandNavigateBack? |
Member
|
Actually, I doubt we need tests for this; it's just a wrapper of the corresponding VSCode command. |
Member
|
Actually, this doesn't seem to work on the current release. I'm guessing it's an issue with the keybindings. |
Contributor
Author
|
Check to see if the "Go Last" command is available in VS Code. My guess is not yet. |
Closed
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 4, 2018
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 4, 2018
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 4, 2018
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 4, 2018
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 6, 2018
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 6, 2018
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 6, 2018
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 6, 2018
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau
added a commit
to dsschnau/Vim
that referenced
this pull request
Dec 6, 2018
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089.
Dependency: microsoft/vscode#33715