Conversation
| let config_yml; | ||
| try { | ||
| config_yml = yaml.safeLoad(fs.readFileSync('./config.yml')); | ||
| config_yml = yaml.load(fs.readFileSync('./config.yml')); |
There was a problem hiding this comment.
safeLoad is deprecated
|
|
||
| let baseurl = config_yml.cliArgs.baseurl; | ||
| if (baseurl.substr(-1) != '/') { | ||
| if (baseurl.substr(-1) !== '/') { |
There was a problem hiding this comment.
implicit conversion warning
| const accessLogStream = rfs.createStream(args.logdir + '/access.log', { | ||
| compress: 'gzip', | ||
| size: args.logsize | ||
| size: args.logsize, |
There was a problem hiding this comment.
lots of prettier warnings fixed
|
LGTM, ty |
|
didn't check router requests yet: valhalla worked, so should be all fine |
|
On an Ubuntu 20.04 box, I'm getting warnings on the node version: npm WARN notsup Unsupported engine for husky@7.0.2: wanted: {"node":">=12"} (current: {"node":"10.19.0","npm":"6.14.5"})
npm WARN notsup Not compatible with your version of node/npm: husky@7.0.2
npm WARN notsup Unsupported engine for commander@8.2.0: wanted: {"node":">= 12"} (current: {"node":"10.19.0","npm":"6.14.5"})
npm WARN notsup Not compatible with your version of node/npm: commander@8.2.0This was the reason why I did not update |
|
ouch.. didn't test it (and frankly didn't think about it), but will do so quickly with a docker image. I'm on v14.17.4. we can look into having a quick github actions check, at least for ubuntu-20.04? arch linux just isn't the safest dev env;) |
|
fwiw, in fact node v10 is unsupported (not even security fixes anymore), v12 is the current LTR: https://endoflife.date/nodejs. but out-of-the-box ubuntu-20.04 support has of course priority |
That's my point since running on latest Ubuntu LTS is a de facto standard for many users. Maybe this only means downgrading a couple dependencies to suppress warnings? |
This reverts commit ae28030.
|
Sorry for premature merge, it is probably not worth it (yet...) happy both if we revert? |
|
can happen. it's necessary to upgrade, there's a dependency conflict, it's what this PR is fixing, see #87 . about to open another one |
fixes #87
was waiting for some process to finish, so I quickly updated the deps. next docker release might fail otherwise too..
I checked with vroom master: health endpoint works, but didn't check any router request.