Thread and exploration options#42
Conversation
|
Thanks @cedricroc for this PR! It could indeed be convenient to be able to expose more parameters on the client-side. For consistency, I think that the config parameters in So Another benefit of this approach would be that people that don't want to expose those parameters on the client-side would now have a simple way to change the defaults right from the config. |
|
Hi @jcoupey, |
| typeof req.body.options.t == "number" | ||
| ) { | ||
| reqOptions.push('-t ' + req.body.options.t); | ||
| args.threads = req.body.options.t; |
There was a problem hiding this comment.
This would override the default value at server level, so subsequent requests with no t option won't use the default setting any more. We should define a local threads variable initialized with args.threads before this check and update if required.
| typeof req.body.options.x == "number" | ||
| ) { | ||
| reqOptions.push('-x ' + req.body.options.x); | ||
| args.explore = req.body.options.x; |
|
I've not seen replace default value. I corrected |
|
Thanks @cedricroc for the changes and submitting this PR! I've done a couple minor adjustements:
|
Override thread and explore options. Same geometry option.