Skip to content

feat(Title): Don't link Component with level by default#6161

Merged
mendrew merged 3 commits intomasterfrom
mendrew/feat/4700/Title/drop-link-of-component-with-level-prop
Nov 29, 2023
Merged

feat(Title): Don't link Component with level by default#6161
mendrew merged 3 commits intomasterfrom
mendrew/feat/4700/Title/drop-link-of-component-with-level-prop

Conversation

@mendrew
Copy link
Copy Markdown
Contributor

@mendrew mendrew commented Nov 29, 2023


  • e2e-тесты
  • Гайд миграции

Описание

Убираем зависимость тэга, используемого по умолчанию, от свойства level.
Задаём span как тэг по умолчанию.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 29, 2023

size-limit report 📦

Path Size
JS 337.06 KB (-0.01% 🔽)
JS (gzip) 102.68 KB (-0.02% 🔽)
JS (brotli) 84.97 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 260.07 KB (0%)
CSS (gzip) 33.82 KB (0%)
CSS (brotli) 27.42 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 29, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 29, 2023

👀 Docs deployed

Commit 73f0b75

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Nov 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 73f0b75:

Sandbox Source
VKUI TypeScript Configuration

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25f2de6) 80.00% compared to head (73f0b75) 79.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6161      +/-   ##
==========================================
- Coverage   80.00%   79.99%   -0.01%     
==========================================
  Files         311      311              
  Lines        9785     9784       -1     
  Branches     3285     3285              
==========================================
- Hits         7828     7827       -1     
  Misses       1957     1957              
Flag Coverage Δ
unittests 79.99% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew changed the title Don't link Component with level by default feat(Title): Don't link Component with level by default Nov 29, 2023
@mendrew mendrew force-pushed the mendrew/feat/4700/Title/drop-link-of-component-with-level-prop branch 2 times, most recently from 3a00a94 to 09ac9a0 Compare November 29, 2023 13:00
@mendrew mendrew force-pushed the mendrew/feat/4700/Title/drop-link-of-component-with-level-prop branch from 09ac9a0 to 77cb01e Compare November 29, 2023 13:03
@mendrew mendrew marked this pull request as ready for review November 29, 2023 13:28
@mendrew mendrew requested a review from a team as a code owner November 29, 2023 13:28
@mendrew mendrew merged commit 1831867 into master Nov 29, 2023
@mendrew mendrew deleted the mendrew/feat/4700/Title/drop-link-of-component-with-level-prop branch November 29, 2023 14:10
eugpoloz pushed a commit that referenced this pull request Nov 30, 2023
Убираем зависимость тэга, используемого по умолчанию, от свойства level.
Задаём span как тэг по умолчанию.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Title]: Отвязать Component от level

4 participants