Conversation
Contributor
size-limit report 📦
|
eugpoloz
reviewed
Nov 24, 2023
Contributor
e2e tests |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6e8bf4b:
|
Contributor
👀 Docs deployed
Commit 6e8bf4b |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6133 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 318 318
Lines 10078 10078
Branches 3396 3396
=======================================
Hits 8041 8041
Misses 2037 2037
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
approved these changes
Nov 24, 2023
SevereCloud
requested changes
Nov 24, 2023
Contributor
SevereCloud
left a comment
There was a problem hiding this comment.
Нужна документация в мигрейшон гайд
a40aac1 to
1a40cd1
Compare
fixes: #4697 Because by default it's more about visual difference. If user needs another compoent - can change the Component prop.
1a40cd1 to
6e8bf4b
Compare
Contributor
Author
|
@SevereCloud обновли migration guide ⚡ 6e8bf4b |
inomdzhon
approved these changes
Nov 29, 2023
SevereCloud
approved these changes
Nov 29, 2023
eugpoloz
pushed a commit
that referenced
this pull request
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Componentнаspan#4697Описание
Меняем тэг, в котором контент рендерится по-умолчанию , на
span, потому чтоSubheadв первую очередь визуальный компонент. Если надо поменять тэг, можно воспользоваться свойствомComponent.