Skip to content

BREAKING CHANGE: [Headlline] change default Component to span#6130

Merged
mendrew merged 5 commits intomasterfrom
mendrew/feat/4698/Headline/change-default-component-to-span
Nov 29, 2023
Merged

BREAKING CHANGE: [Headlline] change default Component to span#6130
mendrew merged 5 commits intomasterfrom
mendrew/feat/4698/Headline/change-default-component-to-span

Conversation

@mendrew
Copy link
Copy Markdown
Contributor

@mendrew mendrew commented Nov 22, 2023


  • Документация фичи

Описание

Меняем тэг, в котором контент рендерится по-умолчанию , на span, потому что Headline в первую очередь визуальный компонент. Если надо поменять тэг, можно воспользоваться свойством Component.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 22, 2023

size-limit report 📦

Path Size
JS 342.23 KB (+0.01% 🔺)
JS (gzip) 105.03 KB (-0.01% 🔽)
JS (brotli) 86.41 KB (-0.03% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.47 KB (0%)
CSS (gzip) 33.98 KB (0%)
CSS (brotli) 27.54 KB (0%)

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Nov 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7be5c7c:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 22, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 22, 2023

👀 Docs deployed

Commit 7be5c7c

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf79a74) 79.54% compared to head (7be5c7c) 79.54%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6130   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files         313      313           
  Lines        9842     9842           
  Branches     3326     3326           
=======================================
  Hits         7829     7829           
  Misses       2013     2013           
Flag Coverage Δ
unittests 79.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review November 24, 2023 12:13
@mendrew mendrew requested a review from a team as a code owner November 24, 2023 12:13
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужна документация в мигрейшон гайд

@mendrew mendrew marked this pull request as draft November 27, 2023 06:45
@mendrew mendrew force-pushed the mendrew/feat/4698/Headline/change-default-component-to-span branch from fb69c34 to 7be5c7c Compare November 29, 2023 10:38
@mendrew mendrew marked this pull request as ready for review November 29, 2023 10:40
@mendrew mendrew requested a review from SevereCloud November 29, 2023 10:40
@mendrew
Copy link
Copy Markdown
Contributor Author

mendrew commented Nov 29, 2023

@SevereCloud Обновил migration guide: 7be5c7c

@mendrew mendrew merged commit 0c687c7 into master Nov 29, 2023
@mendrew mendrew deleted the mendrew/feat/4698/Headline/change-default-component-to-span branch November 29, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Headline]: Поменять дефолтный Component на span

4 participants