tech(css modules): deprecate getPlatformClassName()#4315
Merged
SevereCloud merged 1 commit intomasterfrom Feb 27, 2023
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f913656:
|
Contributor
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4315/ |
Contributor
size-limit report 📦
|
BlackySoul
reviewed
Feb 22, 2023
BlackySoul
reviewed
Feb 22, 2023
SevereCloud
reviewed
Feb 22, 2023
packages/vkui/src/components/PanelHeaderContent/PanelHeaderContent.tsx
Outdated
Show resolved
Hide resolved
Remove notes about getPlatformClassName() in docs: * styleguide/pages/mirgration_v5.md * styleguide/pages/utils.md * docs/TESTING.md
1d295e0 to
f913656
Compare
Codecov ReportBase: 69.53% // Head: 69.46% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #4315 +/- ##
==========================================
- Coverage 69.53% 69.46% -0.07%
==========================================
Files 375 375
Lines 8051 8053 +2
Branches 2839 2848 +9
==========================================
- Hits 5598 5594 -4
- Misses 2453 2459 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SevereCloud
approved these changes
Feb 27, 2023
BlackySoul
approved these changes
Feb 27, 2023
Contributor
❌ PatchНе удалось автоматически применить исправление на стабильной ветке.
Чтобы исправление попало в стабильную ветку, выполните следующие действия:
git stash # опционально
git fetch origin 5.2-stable
git checkout -b patch/pr4315 origin/5.2-stable
git cherry-pick f9136566fb05af7bb08d7204a30988d305fa7777
git push --set-upstream origin patch/pr4315
gh pr create --base 5.2-stable --title "patch: pr4315" --body "- patch #4315" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPlatformClassName()#4272