docs: fix test command in CONTRIBUTING.md to use uv run#520
docs: fix test command in CONTRIBUTING.md to use uv run#520onuratakan merged 1 commit intomasterfrom
Conversation
Review: docs: fix test command in CONTRIBUTING.md to use uv runSummaryGood catch — the bare Observations & Suggestions1.
uv pip install -e ".[vectordb,storage,models,embeddings,tools]"Consider whether the test commands could mirror that scoping, e.g.: uv run --extra tools pytest tests/unit_tests -v
uv run --extra tools pytest tests/unit_tests/tools/test_common_tools_duckduckgo.py -v
uv run --extra storage pytest tests/smoke_tests/memory -vThis would be faster and more instructive to contributors about which extras each test suite actually needs. That said, 2. Inconsistency with CLAUDE.md
# Run all tests
uv run pytest
# Run specific test directory
uv run pytest tests/rag/The two files now give different invocation patterns for the same tool. It would be worth aligning them — either add 3. Makefile smoke_tests target is still bare The 4. No issues with the changes themselves The three-line diff is correct as written:
VerdictThe fix is valid and an improvement over the status quo. The suggestions above are about scope/consistency rather than correctness. Happy to approve as-is if the maintainers are fine with the |
uv run --all-extrasprefix.Full Changelog: master...upsonic/contributing-test-command
Pull Request: