Expose OpenSeadragon tile timeout option#1514
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @skairunner, this makes sense to me.
One small request: we've added a configuration manual to the project. Can you also add documentation for this new setting to that file in the appropriate place? (I'm also happy to help if you need me to, but hopefully this isn't too difficult :-) ).
|
No problem @demiankatz , I've pushed a new commit that updates the config.md. Hope it checks out! Edit: My IDE inserted a space after every header as part of linting, it seems. I hope that's not a problem. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @skairunner, this seems to work as expected for me -- if I set a very short tileTimeout, I get timeout errors; otherwise things work as normal.
Regarding the linting of the Markdown, it might be better to paste the new config setting:
##### tileTimeout
**Type**: `number`
**Default**: `30_000`
Controls the maximum amount of time in milliseconds OpenSeadragon allows for any tile operation.
into the existing documentation without all the other lint changes; otherwise, the history is harder to read here.
I'm definitely open to having better linting on Markdown files, but I think it would be better to handle that in a separate PR (and preferably with some automated tool to help with ongoing enforcement/consistency) rather than making lots of unrelated changes here.
(I tried to save you time by directly editing the file myself, but unfortunately I don't seem to have write access to update this PR).
|
No problem, I'll fix up my PR tomorrow and let you know once it's good to
go.
…On Mon, Jul 28, 2025, 17:47 Demian Katz ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks, @skairunner <https://github.com/skairunner>, this seems to work
as expected for me -- if I set a very short tileTimeout, I get timeout
errors; otherwise things work as normal.
Regarding the linting of the Markdown, it might be better to paste the new
config setting:
##### tileTimeout
**Type**: `number`
**Default**: `30_000`
Controls the maximum amount of time in milliseconds OpenSeadragon allows for any tile operation.
into the existing documentation without all the other lint changes;
otherwise, the history is harder to read here.
I'm definitely open to having better linting on Markdown files, but I
think it would be better to handle that in a separate PR (and preferably
with some automated tool to help with ongoing enforcement/consistency)
rather than making lots of unrelated changes here.
(I tried to save you time by directly editing the file myself, but
unfortunately I don't seem to have write access to update this PR).
—
Reply to this email directly, view it on GitHub
<#1514 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA22VO3IXGDRJEERJO3NBNL3KZAYNAVCNFSM6AAAAACCQFNPE6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANRTGQ3DKMZVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Also update default config docs
7e0088e to
67c2088
Compare
|
@demiankatz Should be good to go! |
demiankatz
left a comment
There was a problem hiding this comment.
@skairunner, just one more request: can you move the documentation for the new setting up a few lines so it falls between subtitleEnabled and titleEnabled? We're trying to keep these in alphabetical order. Apologies for the nuisance!
(Note: it looks like one existing setting -- requiredStatementEnabled -- is also out of order; if you want to move that down a couple of spots while you're fixing the new issue, please feel free).
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @skairunner, and apologies for the extra hoops at the end. I appreciate you taking the time to contribute this back to us!
|
Note that there was a test failure in the automatic build, but this seems to be related to GitHub Actions running slowly rather than the changes in this PR; it passed on a retry. |
Description of what you did:
Resolve UniversalViewer/user-stories#70 by exposing the OpenSeadragon configuration to set the maximum time a tile operation can take.