Skip to content

Returns iiif metadata component behavior to main application#1463

Merged
demiankatz merged 4 commits into
devfrom
issue-1399-dependency-consolidation-iiif-metadata-component
Jul 1, 2025
Merged

Returns iiif metadata component behavior to main application#1463
demiankatz merged 4 commits into
devfrom
issue-1399-dependency-consolidation-iiif-metadata-component

Conversation

@K8Sewell

Copy link
Copy Markdown
Contributor

Summary

Begins consolidated of dependencies back into main application. @iiif/iiif-metadata-component behavior has been migrated from commit ab1add879874bfc3e8e2ad85a1bff480e413bfec into the uv-shared-modules.

Related Ticket

#1399

Screenshot

image

@vercel

vercel Bot commented Jun 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
universalviewer βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 1, 2025 4:36pm

@demiankatz

Copy link
Copy Markdown
Contributor

Thanks, @K8Sewell. I've opened IIIF-Commons/iiif-metadata-component#50 to add a message about the archiving of the component. We should merge that PR and actually archive the repository after the work here is done.

Please take a look at the message I have written and feel free to comment on the PR if you have suggested improvements or changes!

@demiankatz

Copy link
Copy Markdown
Contributor

I've taken a closer look at the iiif-metadata-component repository to see if there is anything else in there that we might want to carry forward, but I do not believe that there is -- no tests, etc. I believe that the work here is complete.

However, while testing this, I noticed that text collapsing no longer works. However, that problem appears to have existed since the 4.2.0 release, so it is not related to the refactoring here. I have opened #1464 to track the issue. I'm not sure whether we should find a solution to that problem before merging this. It's possible that the refactoring here will actually make finding a solution easier, but I have not had time to investigate in any detail.

@LanieOkorodudu

Copy link
Copy Markdown
Contributor

Tested this on my end and reviewed the changes, all looks good! I also checked the PR 'Add "archived" note to README, which @K8Sewell approved, so that one is ready to merge as well. This PR should be all set unless anyone has concerns.
@demiankatz , since you're more familiar with the work, I'll leave it to you to approve this PR. Thanks, everyone!

@demiankatz

Copy link
Copy Markdown
Contributor

Thanks, @LanieOkorodudu! I will make the v4.2.1 release first, since that will cause minor conflicts here. I'll then resolve the conflicts here and merge this, assuming all continues working.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, conflicts have been resolved and fixes from v4.2.1 are incorporated.

@demiankatz demiankatz merged commit 82185ad into dev Jul 1, 2025
6 checks passed
@demiankatz demiankatz deleted the issue-1399-dependency-consolidation-iiif-metadata-component branch July 1, 2025 16:37
@github-project-automation github-project-automation Bot moved this from IN TESTING to COMPLETED in DEV EX Community Sprint May-July 2025 Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

4 participants