Returns iiif metadata component behavior to main application#1463
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
|
Thanks, @K8Sewell. I've opened IIIF-Commons/iiif-metadata-component#50 to add a message about the archiving of the component. We should merge that PR and actually archive the repository after the work here is done. Please take a look at the message I have written and feel free to comment on the PR if you have suggested improvements or changes! |
|
I've taken a closer look at the iiif-metadata-component repository to see if there is anything else in there that we might want to carry forward, but I do not believe that there is -- no tests, etc. I believe that the work here is complete. However, while testing this, I noticed that text collapsing no longer works. However, that problem appears to have existed since the 4.2.0 release, so it is not related to the refactoring here. I have opened #1464 to track the issue. I'm not sure whether we should find a solution to that problem before merging this. It's possible that the refactoring here will actually make finding a solution easier, but I have not had time to investigate in any detail. |
|
Tested this on my end and reviewed the changes, all looks good! I also checked the PR 'Add "archived" note to README, which @K8Sewell approved, so that one is ready to merge as well. This PR should be all set unless anyone has concerns. |
|
Thanks, @LanieOkorodudu! I will make the v4.2.1 release first, since that will cause minor conflicts here. I'll then resolve the conflicts here and merge this, assuming all continues working. |
demiankatz
left a comment
There was a problem hiding this comment.
Okay, conflicts have been resolved and fixes from v4.2.1 are incorporated.
Summary
Begins consolidated of dependencies back into main application.
@iiif/iiif-metadata-componentbehavior has been migrated from commit ab1add879874bfc3e8e2ad85a1bff480e413bfec into the uv-shared-modules.Related Ticket
#1399
Screenshot