Skip to content

Remove redundant config options#1451

Merged
demiankatz merged 1 commit into
UniversalViewer:devfrom
Saira-A:removeconfig
Jun 16, 2025
Merged

Remove redundant config options#1451
demiankatz merged 1 commit into
UniversalViewer:devfrom
Saira-A:removeconfig

Conversation

@Saira-A

@Saira-A Saira-A commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Removes the following configuration options which we established are not needed:

  • elideCount
  • galleryThumbChunkedResizingEnabled
  • pagingOptionEnabled
  • pessimisticAccessControl
  • theme

@vercel

vercel Bot commented Jun 13, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 1:28pm

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Saira-A, this looks good to me. We should be sure to check these boxes on #1449 when we merge this.

@demiankatz

Copy link
Copy Markdown
Contributor

Also, we should remove the related documentation from #1419.

I've put this on the "IN TESTING" column of the sprint board so we don't forget to move it forward.

@LanieOkorodudu

Copy link
Copy Markdown
Contributor

@Saira-A, Thanks for removing these unused config options, looks good!

@demiankatz demiankatz merged commit 3b0c13c into UniversalViewer:dev Jun 16, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from IN TESTING to COMPLETED in DEV EX Community Sprint May-July 2025 Jun 16, 2025
Saira-A added a commit that referenced this pull request Jun 16, 2025
Remove items from  #1451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

3 participants