Add volume control to audio files on mobile devices#1367
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
approved these changes
Apr 15, 2025
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @Saira-A, works on Android for me.
I'm not sure why this PR is showing changes that are already part of the release-4.2.0 branch, though; it's possible you need to pull the upstream version and merge the latest branch to simplify the PR diffs, though I'm sure it will all straighten itself out when we squash and merge regardless.
I'll leave this open in case @LanieOkorodudu or others want to do any further testing first.
Contributor
|
@Saira-A, @demiankatz, Everything looks good now, and the volume control works well in mobile view. Thanks Saira. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1364 - adds config so volume controls are still visible for audio files on mobile devices.
Works on iPhone with Safari, needs to be tested with other devices/browsers