Skip to content

Fix 938 mobile sidebars#1333

Closed
LlGC-jop wants to merge 34 commits into
UniversalViewer:devfrom
LlGC-jop:fix-938-mobile-sidebars
Closed

Fix 938 mobile sidebars#1333
LlGC-jop wants to merge 34 commits into
UniversalViewer:devfrom
LlGC-jop:fix-938-mobile-sidebars

Conversation

@LlGC-jop

@LlGC-jop LlGC-jop commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Description of what you did:

jamesmisson and others added 30 commits February 27, 2025 17:40
@jamesmisson
trigger rightpanel with mobile footer moreinfo button
7fd6e9c
@jamesmisson
Merge remote-tracking branch 'upstream/dev' into UX-mobile-moreinfo
fc03b0d
@jamesmisson
Merge remote-tracking branch 'johnathan/dev' into mobile-trigger-more…
3131b2b 
…info
@jamesmisson
merge jonathan/dev
148200d
@LlGC-jop
Merge pull request #3 from UniversalViewer/dev
bf08f76 
UV -> my dev
@LlGC-jop
Merge pull request #4 from jamesmisson/mobile-trigger-moreinfo
c96037b 
Mobile trigger moreinfo
@github-actions
Commit from GitHub Actions (Lint code)
aa94f0e
@LlGC-jop
Add setting for animationDuration and set on loading the settings dialog
3e3c90a
@LlGC-jop
Set css props from config, update css transitions
227bbc7
@github-actions
Commit from GitHub Actions (Lint code)
1e69e2e
@LlGC-jop
Add extra state class to panels so greater control over child visibil…
12f0fd8 
…ity is possible
@github-actions
Commit from GitHub Actions (Update Documentation)
3f1ad80
@LlGC-jop
Allow panels to choose whether width and height are auto recalc'd to …
e785186 
…parent
@LlGC-jop
Handle a race condition
543c281
@LlGC-jop
Don't let L & R panels have their height set by JS any more
b1286f4
@LlGC-jop
Update transition props and comment out !importants for now
ac6ddbb
@github-actions
Commit from GitHub Actions (Lint code)
b419e8a
@LlGC-jop
tmp add important back to width to fix gallery view issue
a1f6b02
@LlGC-jop
Merge branch 'fix-938-mobile-sidebars' of https://github.com/LlGC-jop…
2e24d1f 
…/universalviewer into fix-938-mobile-sidebars
@LlGC-jop
Don't set the width on the element on full expand - let the css do it
23bd3a1
@LlGC-jop
Add a timeout to allow the resize to finish before resize is done on …
9e4cbbc 
…the gallery
@LlGC-jop
Move setting of the open-finished class so that it happens for both n…
600ed88 
…ormal panel open and full open
@LlGC-jop
Tidy of css and transitions
124daea
@LlGC-jop
contentLeftPanel animation change for testing
cbf4e57
@LlGC-jop
Merge remote-tracking branch 'upstream/dev' into fix-938-mobile-sidebars
6d2adfd
@LlGC-jop
re-remove css that controls sidebar visibility beyond the class-based…
f502926 
… css in styles.less
@LlGC-jop
Restore functions removed by merge
44f4928
@LlGC-jop
Remove redundant center and right panels hiding code
0379267
@LlGC-jop
Remove redundnat block
283e49b
@LlGC-jop
Combine common props
c5ced70
@vercel

vercel Bot commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 1:05pm

@LlGC-jop

LlGC-jop commented Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

Closing due to unexpected conflicts

@LlGC-jop LlGC-jop closed this Mar 10, 2025
demiankatz pushed a commit that referenced this pull request Mar 26, 2025
@jamesmisson
Improve side panel behavior in mobile interface (#1343)
1e2c4b5 
This commit makes side panel functionality fully accessible in the mobile view, where critical features were previously unreachable.

It makes responsive behavior more CSS-based and less dependent on Javascript logic.

It incorporates work from #1321, #1325, #1330, #1333 and #1337.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LlGC-jop @jamesmisson