The latest updates on your projects. Learn more about Vercel for Git ↗︎

@demiankatz, I tested the fix, and it’s working well on my end. I’m able to activate thumbnails using the Space bar without any issues.

One thing I noticed: pressing Enter doesn’t activate the thumbnails, though Space works as expected. Could you please confirm if pressing Enter works on your end? My understanding of the fix is that both Space and Enter should activate the thumbnails.

One thing I noticed: pressing Enter doesn’t activate the thumbnails, though Space works as expected. Could you please confirm if pressing Enter works on your end? My understanding of the fix is that both Space and Enter should activate the thumbnails.

Pressing Enter works for me in both Firefox and Chrome. Note that this fix only applies to the left side panel labeled "Contents." If you are seeing problematic behavior in a different place, that is likely related to different code. Can you please clarify the circumstances where Enter is not working for you?

@demiankatz, Yes, I only tested the fix on the left Contents panel in both Chrome and Firefox. When I hover over the collapse area and press Space, it works as expected. However, pressing Enter doesn’t trigger any response in either browser.

I’ll also ask the rest of the testing team to see if they’re experiencing the same behaviour, just to confirm if both Space and Enter should be working. Hopefully, it’s just my browser acting up!

@demiankatz, Yes, I only tested the fix on the left Contents panel in both Chrome and Firefox. When I hover over the collapse area and press Space, it works as expected. However, pressing Enter doesn’t trigger any response in either browser.

I’ll also ask the rest of the testing team to see if they’re experiencing the same behaviour, just to confirm if both Space and Enter should be working. Hopefully, it’s just my browser acting up!

Thanks, @LanieOkorodudu. When you say "hover," what exactly do you mean? I'm focusing the thumbnails by using the tab key; is there some other method of focusing you're using that might be behaving inconsistently?

@demiankatz, sorry I meant to use tab not hover. Does this fix relate to collapsing content with the space bar and enter keys, or is it specifically for navigating through content using these keys? If the fix is focused on navigation within the content using space and enter, everything seems to be working well.

@demiankatz @LanieOkorodudu Hi Guys, So what I am seeing for #1176 is that space & enter are working for thumbnail navigation, however this preview doesnt yet contain the fix for #1164

When I look at preview #1164 directly, the contents panel arrows are working as expected when clicking the spacebar & enter for keybord navigation

Thanks for the clarification, @damodeburca. Since @LanieOkorodudu has approved #1164, I went ahead and merged that. The changes from #1164 are now incorporated into this PR as well. @LanieOkorodudu, does that make any difference for you?

@demiankatz good to merge #1176 too. Thanks @demiankatz and @damodeburca

@demiankatz , Tested it again to confirm, and everything works as expected now. Thanks again, @demiankatz, for the fix!

Thanks for the confirmation, @LanieOkorodudu -- merging now.